Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Transition client-side logic over to SingleInvokeInitiator & cluster objects #8896

Closed
mrjerryjohns opened this issue Aug 11, 2021 · 5 comments

Comments

@mrjerryjohns
Copy link
Contributor

mrjerryjohns commented Aug 11, 2021

Problem

Once #8894 has been fixed and SingleInvokeInitiator has been implemented, the client-side code that currently interfaces with CommandHandler should be ported over to using this new class + cluster objects.

However, to make this a gradual transition, it has been broken down into 5 different phases that are designed to maximize parallelism and ensure smaller sized PRs:

This is an 'umbrella' issue that to be deemed fixed, requires the above 5 issues to be fixed first.

@mrjerryjohns mrjerryjohns changed the title [☂️] Transition client-side logic over to SingleInvokeInitiator & cluster objects ☂️ Transition client-side logic over to SingleInvokeInitiator & cluster objects Aug 11, 2021
@mrjerryjohns
Copy link
Contributor Author

Will add links to the above issues tomorrow...

@mrjerryjohns
Copy link
Contributor Author

@bzbarsky-apple FYI.

@woody-apple
Copy link
Contributor

What is the impact of this?

@bzbarsky-apple
Copy link
Contributor

The main impacts I know about:

  • Broken error-handling in commissioning because the APIs it's using don't propagate out errors correctly.
  • Lots of nearly-unused code floating around that we could delete if we stopped using the last few bits of it.

Fixing #13371 is likely to fix this, fwiw.

@yunhanw-google
Copy link
Contributor

this has been fixed for C1-C5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants