Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cecille): need to better document this value. Why is the comment different than... #8796

Closed
todo bot opened this issue Aug 4, 2021 · 1 comment
Closed

(cecille): need to better document this value. Why is the comment different than... #8796

todo bot opened this issue Aug 4, 2021 · 1 comment
Assignees
@cecille
Labels
todo

Comments

@todo
Copy link

todo bot commented Aug 4, 2021

connectedhomeip/src/lib/mdns/minimal/core/DnsHeader.h

Lines 80 to 84 in 7c413b8

// TODO(cecille): need to better document this value. Why is the comment different than the value?
static constexpr uint16_t kMdnsNonIgnoredMask = 0x8E08;
static constexpr uint16_t kIsResponseMask = 0x8000;
static constexpr uint16_t kOpcodeMask = 0x7000;

This issue was generated by todo based on a TODO comment in 7c413b8 when #8610 was merged. cc @cecille.
@todo todo bot added the todo label Aug 4, 2021
@todo todo bot assigned cecille Aug 4, 2021
@carol-apple
Copy link
Contributor

This is a dupe of #8797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cecille cecille

Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cecille @carol-apple