Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some unit testing for Mdns::StartServer #8769

Open
bzbarsky-apple opened this issue Aug 3, 2021 · 3 comments
Open

Create some unit testing for Mdns::StartServer #8769

bzbarsky-apple opened this issue Aug 3, 2021 · 3 comments
Labels

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We don't really have any tests for Mdns::StartServer. This leads to major bugs like #7911 not being noticed, and workarounds being put in place (like the AdvertiseOperational call instead of StartServer in emberAfOperationalCredentialsClusterAddNOCCallback

Proposed Solution

Add unit testing for this code.

@cecille @andy31415

@stale
Copy link

stale bot commented Aug 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 16, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Aug 26, 2022
@stale
Copy link

stale bot commented Mar 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 11, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 13, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants