Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandHandler::ProcessCommandDataElement broken for group paths #8645

Closed
bzbarsky-apple opened this issue Jul 27, 2021 · 4 comments
Closed

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

CommandHandler::ProcessCommandDataElement does:

    err = commandPath.GetEndpointId(&endpointId);
    SuccessOrExit(err);

but this will fail for group paths. What should instead happen is that if there is no endpoint id we check for a group id (which is NOT in the command path; it's in the packet header, iirc), and then loop over all endpoints in the group doing the command on each endpoint.

Proposed Solution

Fix things so group commands work, like they used to work in the Ember code.

@yunhanw-google @erjiaqing

@yunhanw-google
Copy link
Contributor

OK, we would handle it, we also need to remove group id from IM command path in MessageDef

@bzbarsky-apple
Copy link
Contributor Author

@mrjerryjohns should probably confirm what the encoding side looks like before we start changing it.

@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jan 26, 2022
@stale stale bot removed the stale Stale issue or PR label Jan 26, 2022
@bzbarsky-apple
Copy link
Contributor Author

Fixed in #13833.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants