Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to max(commissionable TXT key size, operational TXT key size) after optim... #8467

Closed
todo bot opened this issue Jul 17, 2021 · 0 comments · Fixed by #8614
Closed

Switch to max(commissionable TXT key size, operational TXT key size) after optim... #8467

todo bot opened this issue Jul 17, 2021 · 0 comments · Fixed by #8614
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Jul 17, 2021

// TODO: Switch to max(commissionable TXT key size, operational TXT key size) after optimizing memory usage
static constexpr uint8_t kMaxDnsServiceTxtKeySize = Mdns::OperationalAdvertisingParameters::kTxtMaxKeySize;
#else
// Thread only supports operational discovery.
static constexpr uint8_t kMaxDnsServiceTxtEntriesNumber = Mdns::OperationalAdvertisingParameters::kTxtMaxNumber;
static constexpr uint8_t kMaxDnsServiceTxtValueSize = Mdns::OperationalAdvertisingParameters::kTxtMaxValueSize;
static constexpr uint8_t kMaxDnsServiceTxtKeySize = Mdns::OperationalAdvertisingParameters::kTxtMaxKeySize;
#endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD_COMMISSIONABLE_DISCOVERY
DnsBrowseCallback mDnsBrowseCallback;


This issue was generated by todo based on a TODO comment in 6c84a76 when #8370 was merged. cc @Damian-Nordic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant