Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make this large number (1k+) to catch some signature serialization corne... #8394

Closed
todo bot opened this issue Jul 14, 2021 · 1 comment
Closed
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Jul 14, 2021

// TODO: Need to make this large number (1k+) to catch some signature serialization corner cases
// but this is too slow on QEMU/embedded, so we need to parametrize. Signing with ECDSA
// is non-deterministic by design (since knowledge of the value `k` used allows recovery
// of the private key).
constexpr int kNumSigningIterations = 3;
for (int i = 0; i < kNumSigningIterations; ++i)
{
P256ECDSASignature signature;
CHIP_ERROR signing_error = keypair.ECDSA_sign_hash(hash, hash_length, signature);
NL_TEST_ASSERT(inSuite, signing_error == CHIP_NO_ERROR);


This issue was generated by todo based on a TODO comment in af85572 when #8236 was merged. cc @tcarmelveilleux.
@todo todo bot added the todo label Jul 14, 2021
@carol-apple
Copy link
Contributor

This is a dupe of #8395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants