Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When multi-admin is enabled, operational does not need to be cleared here. #8037

Closed
todo bot opened this issue Jun 30, 2021 · 2 comments · Fixed by #8962
Closed

When multi-admin is enabled, operational does not need to be cleared here. #8037

todo bot opened this issue Jun 30, 2021 · 2 comments · Fixed by #8962
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Jun 30, 2021

// TODO: When multi-admin is enabled, operational does not need to be cleared here.
if (params.GetCommissionAdvertiseMode() == CommssionAdvertiseMode::kCommissionableNode)
{
mQueryResponderAllocatorCommissionable.Clear();
}
else
{
mQueryResponderAllocatorCommissioner.Clear();
}
// TODO: need to detect colisions here


This issue was generated by todo based on a TODO comment in b83cbfc when #7615 was merged. cc @cecille.
@bzbarsky-apple
Copy link
Contributor

@cecille I don't understand that TODO comment... operational advertisement is not being cleared in that code anyway.

@cecille
Copy link
Contributor

cecille commented Aug 12, 2021

Ah - this is a TODO that has been to-done already, but the comment remained as a reminder of days past. I will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants