Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mdns to support arbitrary number of fabrics. #8000

Closed
cecille opened this issue Jun 29, 2021 · 6 comments
Closed

Adjust mdns to support arbitrary number of fabrics. #8000

cecille opened this issue Jun 29, 2021 · 6 comments
Assignees
Labels
maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. spec Mismatch between spec and implementation V1.0

Comments

@cecille
Copy link
Contributor

cecille commented Jun 29, 2021

Problem

Need to adjust mdns to support the number of fabrics the device actually supports.

see: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/2551

Proposed Solution

Template response sender, get setting from wherever that info comes into the SDK.

@cecille
Copy link
Contributor Author

cecille commented Jul 28, 2021

There was also a request to support arbitrary numbers of fabrics for the more capable devices - see PR #8610. In general, this is something we will need to tackle on a larger scale - what's CHIP's philosophy on static vs. dynamic allocation and do we support multiple configs of this?

@cecille
Copy link
Contributor Author

cecille commented Jul 30, 2021

Note: possible good solution would be to hook into the in-progress pool impl. #8299

@cecille
Copy link
Contributor Author

cecille commented Apr 19, 2022

@andy31415 - I had an issue opened for this. I think you've done this already? I know you were working on it. If so, would you mind closing this.

@bzbarsky-apple
Copy link
Contributor

@cecille Is this issue about minimal mdns specifically, or mdns in general?

For minimal mdns we have:

using QueryResponderPtrPool = std::array<mdns::Minimal::QueryResponderBase *, CHIP_CONFIG_MAX_FABRICS + 2>;

which should have enough space for CHIP_CONFIG_MAX_FABRICS operational things, commissionable discovery, commissioner discovery.

For platform mdns I don't know where things stand on the various platforms.

@bzbarsky-apple bzbarsky-apple added the maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. label May 4, 2022
@andy31415
Copy link
Contributor

Maximum number of records returned is configurable - #16535 added that functionality.

@andy31415
Copy link
Contributor

Marking as closed: combination of #16535 and #16181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

5 participants