Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tv-app command processing is broken and untested #7602

Closed
bzbarsky-apple opened this issue Jun 14, 2021 · 4 comments
Closed

tv-app command processing is broken and untested #7602

bzbarsky-apple opened this issue Jun 14, 2021 · 4 comments
Assignees

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

If I look at MediaPlaybackManager, it has things like this:

bool emberAfMediaPlaybackClusterMediaFastForwardCallback(chip::app::Command *)
{
    EmberAfMediaPlaybackStatus status = MediaPlaybackManager().proxyMediaPlaybackRequest(MediaPlaybackRequest::FastForward);
    sendResponse("MediaFastForward", ZCL_MEDIA_FAST_FORWARD_RESPONSE_COMMAND_ID, status);
    return true;
}

where sendResponse encodes a response in the ZCL encoding, which does not match the Matter command/response encoding. This is obviously broken, in that the sender will not be able to decode the response, but nothing in CI tests this, so no one notices.

Proposed Solution

Encode the response commands properly and add CI for tv-app.

@chrisdecenzo

@lazarkov
Copy link
Contributor

@bzbarsky-apple I'm working on this.

@bzbarsky-apple
Copy link
Contributor Author

Looks like this got broken by #5945 because that only updated some command impls in the tree, not others? As @lazarkov points out, door-lock is broken too.

@erjiaqing is that expected? Are there issues tracking fixing the various things that #5945 should have fixed and did not?

@lazarkov
Copy link
Contributor

lazarkov commented Jul 1, 2021

This issue is being resolved under PR

@chrisdecenzo chrisdecenzo removed their assignment Aug 10, 2021
@woody-apple
Copy link
Contributor

Looks resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants