You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
where sendResponse encodes a response in the ZCL encoding, which does not match the Matter command/response encoding. This is obviously broken, in that the sender will not be able to decode the response, but nothing in CI tests this, so no one notices.
Proposed Solution
Encode the response commands properly and add CI for tv-app.
Looks like this got broken by #5945 because that only updated some command impls in the tree, not others? As @lazarkov points out, door-lock is broken too.
@erjiaqing is that expected? Are there issues tracking fixing the various things that #5945 should have fixed and did not?
Problem
If I look at
MediaPlaybackManager
, it has things like this:where
sendResponse
encodes a response in the ZCL encoding, which does not match the Matter command/response encoding. This is obviously broken, in that the sender will not be able to decode the response, but nothing in CI tests this, so no one notices.Proposed Solution
Encode the response commands properly and add CI for tv-app.
@chrisdecenzo
The text was updated successfully, but these errors were encountered: