Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIP Certificate: Update ECDSA Signature Representation #7382

Closed
emargolis opened this issue Jun 4, 2021 · 1 comment
Closed

CHIP Certificate: Update ECDSA Signature Representation #7382

emargolis opened this issue Jun 4, 2021 · 1 comment

Comments

@emargolis
Copy link
Contributor

Problem

Currently SDK implements ECDSA signature in the CHIP Certificate as a TLV structure of R and S parameters:

ecdsa-signature => STRUCTURE [tag-order]
{
    r [1]   : OCTET STRING,
    s [2]   : OCTET STRING,
}

Recently, the spec was updated to represent ECDSA signature as Octet String:

ec-signature => OCTET STRING [ length (CHIP_CRYPTO_GROUP_SIZE_BYTES * 2) ]

Proposed Solution

Update implementation to match the spec.
@emargolis emargolis mentioned this issue Jun 4, 2021
Merged
@woody-apple
Copy link
Contributor

Looks resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emargolis @woody-apple