Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch NetworkInterfaceType Name member to CHAR_STRING #6805

Closed
bzbarsky-apple opened this issue May 14, 2021 · 3 comments
Closed

Switch NetworkInterfaceType Name member to CHAR_STRING #6805

bzbarsky-apple opened this issue May 14, 2021 · 3 comments
Labels
spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We don't support CHAR_STRING in structs yet. So for now the Name of NetworkInterfaceType in src/app/zap-templates/zcl/custom-types.xml is OCTET_STRING.

Proposed Solution

Once CHAR_STRING is supported in structs, use it here.

@vivien-apple
@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label May 14, 2021
@bzbarsky-apple bzbarsky-apple mentioned this issue May 14, 2021
Closed
@bzbarsky-apple
Copy link
Contributor Author

Might be a dup of #6112

@holbrookt holbrookt mentioned this issue May 25, 2021
Merged
@andy31415 andy31415 added v1_triage_split_5 V1.0 spec Mismatch between spec and implementation and removed V1.0 spec Mismatch between spec and implementation labels Jan 30, 2022
@mrjerryjohns
Copy link
Contributor

I can't seem to find NetworkInterfaceType in the cluster specs anymore. More-over, char string is now supported. Marking as stale.

@bzbarsky-apple
Copy link
Contributor Author

I can't seem to find NetworkInterfaceType in the cluster specs anymore

In the spec it's called "NetworkInterface struct". In our XML it's NetworkInterfaceType.

That said, its Name is CHAR_STRING in the XML, so we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andy31415 @mrjerryjohns @woody-apple @bzbarsky-apple