Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing write or readLength = 0 as an argument to emAfReadOrWriteAttribute is unsafe #5897

Closed
vivien-apple opened this issue Apr 9, 2021 · 2 comments

Comments

@vivien-apple
Copy link
Contributor

Passing a 0 readLength here is just asking for trouble in memory safety terms for both reads and writes. Please make sure a followup is filed to stop doing that, marked as a critical security problem. Or fix it before landing, I guess....

Originally posted by @bzbarsky-apple in #5020 (comment)

@tcarmelveilleux
Copy link
Contributor

A bit more context since the original PR conversation link does not expand:

image

@bzbarsky-apple
Copy link
Contributor

Note that the code in question (the caller of emAfReadOrWriteAttribute) is gone now. The API itself still has issues, but this callsite is not one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants