Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Protocol IDs in src/protocols/Protocols.h #5441

Closed
holbrookt opened this issue Mar 17, 2021 · 1 comment
Closed

Fix Protocol IDs in src/protocols/Protocols.h #5441

holbrookt opened this issue Mar 17, 2021 · 1 comment
Labels
spec Mismatch between spec and implementation

Comments

@holbrookt
Copy link
Contributor

Problem

Protocol IDs have been assigned somewhat randomly in Protocols.h. They should be edited to reflect the values assigned in the spec.

Proposed Solution

IDs should be edited to reflect the spec.
@holbrookt holbrookt added the spec Mismatch between spec and implementation label Mar 17, 2021
@holbrookt holbrookt mentioned this issue Mar 17, 2021
Merged
@holbrookt
Copy link
Contributor Author

Seems to have been fixed by #9851 and #6631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy31415 @holbrookt @woody-apple