Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of packed certificate time in the code #4692

Closed
bzbarsky-apple opened this issue Feb 5, 2021 · 2 comments
Closed

Get rid of packed certificate time in the code #4692

bzbarsky-apple opened this issue Feb 5, 2021 · 2 comments
Assignees
@emargolis
Labels
crypto spec Mismatch between spec and implementation

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

Packed certificate time has been removed from the spec, replaced by CHIP epoch time. We should update the code accordingly.

Proposed Solution

Remove PackCertTime, UnpackCertTime. Figure out what to do with PackedCertTimeToDate and PackedCertDateToTime. Replace SecondsSinceEpochToPackedCertTime with something that produces CHIP epoch times. Update comments on mEffectiveTime. Figure out what happens with mNotBeforeDate and mNotAfterDate.

@emargolis do you have bandwidth for this?
@bzbarsky-apple bzbarsky-apple added crypto spec Mismatch between spec and implementation labels Feb 5, 2021
@emargolis
Copy link
Contributor

Yes, will work on that this week.

@emargolis emargolis mentioned this issue Feb 17, 2021
Closed
@andy31415
Copy link
Contributor

Fixed by #4888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emargolis emargolis

Labels
crypto spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy31415 @emargolis @bzbarsky-apple