Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface in Transport Layer to allows the messaging layer configure packet header #4641

Closed
yufengwangca opened this issue Feb 3, 2021 · 3 comments
Closed

Add interface in Transport Layer to allows the messaging layer configure packet header #4641

yufengwangca opened this issue Feb 3, 2021 · 3 comments
Assignees
@yufengwangca

Comments

@yufengwangca
Copy link
Contributor

Problem

Currently, we only can configure payload header before sending message to transport layer. Packetheader are auto-configured in Transport layer

Proposed Solution

Add interface in Transport Layer to allows the messaging layer configure packet header
@yufengwangca yufengwangca self-assigned this Feb 3, 2021
@woody-apple
Copy link
Contributor

What feature is this for?

@yufengwangca
Copy link
Contributor Author

To allow the upper layer configure the message. Such as we shall set the C flag in the packet header for certain type of control message.

@todo todo bot mentioned this issue Feb 8, 2021
Merged
@yufengwangca yufengwangca mentioned this issue Feb 9, 2021
Closed
@yufengwangca
Copy link
Contributor Author

Per Boris, we temperately use hard-code method to configure C-flag since only two messages use this flag in spec now. Close it for now,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yufengwangca yufengwangca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow app to set the C flag in the packet header for control message.
2 participants
@yufengwangca @woody-apple