[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx` #33733

yunhanw-google · 2024-06-04T16:17:23Z

          Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx`

Originally posted by @tcarmelveilleux in #33533 (comment)

The text was updated successfully, but these errors were encountered:

yunhanw-google mentioned this issue Jun 4, 2024

[python] Add ICD support to Python binding #33533

Merged

yunhanw-google assigned erjiaqing Jun 4, 2024

bzbarsky-apple added the python label Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx` #33733

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx` #33733

yunhanw-google commented Jun 4, 2024

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called sXxx if it's not static. It would have needed to be gXxx #33733

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called sXxx if it's not static. It would have needed to be gXxx #33733

Comments

yunhanw-google commented Jun 4, 2024

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx` #33733

[Python][ICD]Direct global access should not be done. There should be a struct with the necessary state and a way to get a pointer to it. This goes across the wall. It can't be called `sXxx` if it's not static. It would have needed to be `gXxx` #33733