Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPM: RMS* and NeutralCurrent attribute value ranges cannot be negative #32050

Open
littlebriars opened this issue Feb 9, 2024 · 2 comments
Open

Comments

@littlebriars
Copy link

By definition these parameters cannot be negative, so the constraint ranges should be changed from (-2^62 to 2^62) to (0 to 2^62).

@bzbarsky-apple
Copy link
Contributor

@littlebriars This is an issue for the spec, not the SDK, right? Is this filed in the wrong place?

@littlebriars
Copy link
Author

littlebriars commented Feb 10, 2024

@littlebriars This is an issue for the spec, not the SDK, right? Is this filed in the wrong place?

Whoops: yes.

I have now raised a spec issue: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/8868

For the test spec, I've already included the fix in https://github.com/CHIP-Specifications/chip-test-plans/pull/3949/, which has just been merged.

For the SDK I noticed this in review of #31616, and suggested it be fixed there, but @jamesharrow is not surprisingly reluctant to include it until there is a spec change too, so suggest we keep this issue open until the SDK is fixed (either in #31616 or if it misses that PR an new PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants