Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM] Revert back InteractionModel::Status to be a class enum #32025

Closed
jepenven-silabs opened this issue Feb 8, 2024 · 0 comments · Fixed by #32110
Closed

[IM] Revert back InteractionModel::Status to be a class enum #32025

jepenven-silabs opened this issue Feb 8, 2024 · 0 comments · Fixed by #32110
Assignees

Comments

@jepenven-silabs
Copy link
Contributor

in PR #32016 the class enum was downgraded to an enum to ease the transition from EmberAfStatus to InteractionModel::Status Once the transition is completed switch it back to class enum

Not changing the class enum to an enum would have double the amount of work needed to do the transition on top of preventing breakage of the transition into multiples small PR. We would have had a 1 or 2 humongous PR doing the switch from one status to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant