Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVSE cluster now won't allow events to be turned on in ZAP #31032

Closed
jamesharrow opened this issue Dec 15, 2023 · 2 comments · Fixed by #30701
Closed

EVSE cluster now won't allow events to be turned on in ZAP #31032

jamesharrow opened this issue Dec 15, 2023 · 2 comments · Fixed by #30701
Assignees
Labels
bug Something isn't working energy evse Issue related to EVSE feature energy

Comments

@jamesharrow
Copy link
Contributor

jamesharrow commented Dec 15, 2023

Reproduction steps

  1. Run ./scripts/tools/zap/run_zaptool.sh examples/energy-management-app/energy-management-common/energy-management-app.zap
  2. Goto EP1, and Energy EVSE cluster
  3. Click on Events tab
  4. Turn on an event

Nothing happens but an error message is sent on console:


    at Object.insertOrUpdateEventState (/home/jebh/workspace/connectedhomeip/.environment/cipd/packages/zap/resources/app.asar/dist/src-electron/db/query-config.js:384:29)

    at /home/jebh/workspace/connectedhomeip/.environment/cipd/packages/zap/resources/app.asar/dist/src-electron/rest/user-data.js:298:9

(Use `zap --trace-warnings ...` to show where the warning was created)

(node:157908) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

I think this is because I was asked to remove side="server" from events in XML.
(ISSUE here: #30665) @bzbarsky-apple

-    <event code="0x0000" name="EVConnected" priority="info" side="server" apiMaturity="provisional">
+    <event code="0x0000" name="EVConnected" priority="info" apiMaturity="provisional">

It would be easy for me to revert the side="server" change, but need a decision on direction here.
[I can confirm that reverting the change makes the issue go away].

Bug prevalence

Every time

GitHub hash of the SDK that was being used

N/A see PR #30857

Platform

core

Platform Version(s)

1.3

Type

Spec Compliance Issue

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor

@jamesharrow If reverting it makes the issue go away, please revert.

And maybe file a ZAP issue on them requiring that in the XML.

@jamesharrow
Copy link
Contributor Author

Reverted in PR #30701

@mergify mergify bot closed this as completed in #30701 Dec 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Grouping] Energy Management Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working energy evse Issue related to EVSE feature energy
Projects
Archived in project
2 participants