Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Potential codesize reduction using Template for EVSE SDK #30994

Open
jamesharrow opened this issue Dec 13, 2023 · 0 comments
Open

[1.3] Potential codesize reduction using Template for EVSE SDK #30994

jamesharrow opened this issue Dec 13, 2023 · 0 comments
Assignees
Labels
bug Something isn't working energy evse Issue related to EVSE feature energy

Comments

@jamesharrow
Copy link
Contributor

Reproduction steps

Per PR review on #30857

@bzbarsky-apple suggested that potentially using a template to only instantiate code if the feature / optional support of attributes and commands code help reduce implementators code size.

Specifically there are some optional features in EVSE (such as charging PREFerences) which could inflate codesize for manufacturers not wanting to support that.

Bug prevalence

N/A

GitHub hash of the SDK that was being used

N/A see PR #30857

Platform

core

Platform Version(s)

1.3

Type

Core SDK Performance Improvement

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working energy evse Issue related to EVSE feature energy
Projects
Status: Todo
Development

No branches or pull requests

1 participant