Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] dependency inversion on platform depending on app/server/Server.h #30598

Open
andy31415 opened this issue Nov 21, 2023 · 1 comment
Open
Assignees

Comments

@andy31415
Copy link
Contributor

We have:

src/platform/silabs/efr32/wifi/wfx_notify.cpp
44:#include <app/server/Server.h>
                                                                                                                                                                                                                                                                               
src/platform/silabs/SiWx917/wifi/wfx_notify.cpp
37:#include <app/server/Server.h>

It does not seem right that a platform file (low level) depends on app (highest level). This breaks layering and dependencies.
Found while checking #30596

@andy31415
Copy link
Contributor Author

We also seem to #include <app/server/Dnssd.h> which is not ok.

Also having #include "AppConfig.h" is unclear to me since I am not sure where AppConfig.h resides and what generates it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants