Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Door Lock Cluster XML has to be updated as per spec #30303

Open
KishokG opened this issue Nov 8, 2023 · 1 comment
Open

[1.3] Door Lock Cluster XML has to be updated as per spec #30303

KishokG opened this issue Nov 8, 2023 · 1 comment
Labels
bug Something isn't working needs triage Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@KishokG
Copy link

KishokG commented Nov 8, 2023

Description

XML has to be updated as per spec:

  • The RID feature is been implemented in SDK and sample app. So the RID feature has to be updated from False to True in Feature map(Row No: 50).
  • DRLK.S.A0025(OperatingMode) - Default value has to be added as per spec(Row No: 139).
  • UserTypeEnum has to be updated as per spec(Row No: 820).
  • ActuatorEnabled, LEDSettings and SoundVolume Attribute data type has to be added in Auxiliary data types.
  • Below Non matter features data type has to be removed(From Row No: 598):
    • KeypadOperationEventMask,
    • RemoteOperationEventMask ,
    • ManualOperationEventMask,
    • RFIDOperationEventMask,
    • KeypadProgrammingEventMask,
    • RemoteProgrammingEventMask,
    • RFIDProgrammingEventMask
  • Below mentioned data types is not available in spec. But it is been mentioned in XML so it has to be removed in XML(From Row No: 774):
    • DoorLockDayOfWeek bitmap
    • DoorLockProgrammingEventCode
    • DoorLockOperationEventCode
    • DoorLockSetPinOrIdStatus
    • DoorLockUserType
    • DoorLockUserStatus
  • SendPINOverTheAir attribute has to be removed in XML(Non Matter).
  • DlStatus enum has to be updated as per spec(Row No:746).

XML Reference:
https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/door-lock-cluster.xml

Specification Reference:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/DoorLock.adoc

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

eb2f8f6

Platform

raspi

Platform Version(s)

RPI - 4, 8GB RAM

Type

Test Improvement

@KishokG KishokG added bug Something isn't working needs triage labels Nov 8, 2023
@bzbarsky-apple
Copy link
Contributor

Please see https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/2448 which needs to be addressed before we change anything in the XML here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
Status: Todo
Development

No branches or pull requests

2 participants