Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Identify ICD Device during auto-commissioning flow #29382

Closed
yunhanw-google opened this issue Sep 21, 2023 · 2 comments · Fixed by #29427
Closed

[ICD] Identify ICD Device during auto-commissioning flow #29382

yunhanw-google opened this issue Sep 21, 2023 · 2 comments · Fixed by #29427
Assignees
@erjiaqing
Labels
icd Intermittently Connected Devices
Milestone
1.3 Feature Complete

Comments

@yunhanw-google
Copy link
Contributor

Read Descriptor Cluster and Check if ICDManagementCluster exists and further check if ICD feature is there or not from global feature map.
@yunhanw-google yunhanw-google converted this from a draft issue Sep 21, 2023
@yunhanw-google yunhanw-google added this to the 1.3 milestone Sep 21, 2023
@bzbarsky-apple bzbarsky-apple added the icd Intermittently Connected Devices label Sep 21, 2023
@erjiaqing erjiaqing changed the title [ICD] Identify ICD Device in self-registration for auto-commissioning flow [ICD] Identify ICD Device during auto-commissioning flow Sep 25, 2023
@github-actions github-actions bot removed the icd Intermittently Connected Devices label Sep 25, 2023
@erjiaqing erjiaqing added the icd Intermittently Connected Devices label Sep 25, 2023
@erjiaqing erjiaqing mentioned this issue Sep 25, 2023
Merged
@yunhanw-google
Copy link
Contributor Author

@erjiaqing We also need to Read attribute "current active mode" to allow dynamic switching of state based upon
https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7556#issuecomment-1734048250

@mkardous-silabs
Copy link
Contributor

@yunhanw-google @erjiaqing I do not think the current active mode is necessary during the commissioning process. A Controller should register to the ICD no matter.

The current active mode once we have decided of its final form will only be used to determine if the controller should or should not buffer commands to the device.

@mergify mergify bot closed this as completed in #29427 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erjiaqing erjiaqing

Labels
icd Intermittently Connected Devices
Projects
[1.3] SDK Feature Complete
Archived in project
[Feature] Intermittently Connected Devices (ICD)
Status: Done
Milestone
1.3 Feature Complete
Development

Successfully merging a pull request may close this issue.

[icd] Add steps for checking ICD during commissioning erjiaqing/connectedhomeip
5 participants
@erjiaqing @yunhanw-google @bzbarsky-apple @mkardous-silabs @NelsonAllegion