Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NXP] Factory reset on fail-safe armed during reboot is wrong #29141

Closed
bzbarsky-apple opened this issue Sep 8, 2023 · 2 comments
Closed

[NXP] Factory reset on fail-safe armed during reboot is wrong #29141

bzbarsky-apple opened this issue Sep 8, 2023 · 2 comments

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

ConfigurationManagerImpl::Init in src/platform/nxp/mw320/ConfigurationManagerImpl.cpp does this:

    if (GetFailSafeArmed(failSafeArmed) == CHIP_NO_ERROR && failSafeArmed)
    {
        ChipLogProgress(DeviceLayer, "Detected fail-safe armed on reboot; initiating factory reset");
        InitiateFactoryReset();
    }

But what if the fail-safe was armed for a second commissioning? This can then wipe out a device that is working just fine.

@doru91

Platform

other

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

@bzbarsky-apple bzbarsky-apple changed the title [NXP] Rebooting on fail-safe armed during reset is wrong [NXP] Factory reset on fail-safe armed during reboot is wrong Sep 8, 2023
@crlonxp
Copy link
Contributor

crlonxp commented Oct 20, 2023

A PR is created for fixing this issue.
#29882
Please help to review.
Thank you

@crlonxp
Copy link
Contributor

crlonxp commented Oct 23, 2023

The PR is approved and merged. Could this bug be closed?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants