Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP transport needs more robust counting of 'in progress connections' #2708

Closed
andy31415 opened this issue Sep 17, 2020 · 3 comments
Closed
Labels
feature work p1 priority 1 work stale Stale issue or PR
Milestone

Comments

@andy31415
Copy link
Contributor

Problem

We expect available connections to:

  • decrease when a 'connect' starts or a connection is received
  • increase wheneve a connection is closed (including connect failures)

In the initial PR, the available count increase/decrease is sprinkled all over making it hard to track. Some more unified and provable correct tracking would be better.

Proposed Solution

Use some form of RAII to increase/decrease the counter. Counters are very tied to active connections, however the fact that we queue 'pending messages' makes things slightly more complex.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.71. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stale
Copy link

stale bot commented Oct 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 22, 2021
@stale
Copy link

stale bot commented Oct 29, 2021

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work p1 priority 1 work stale Stale issue or PR
Projects
None yet
Development

No branches or pull requests

2 participants