Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-WAKEONLAN-4.1] Mac Address returned is Empty for wake-on-lan-mac-address attribute. #25793

Closed
Rajashreekalmane opened this issue Mar 23, 2023 · 4 comments · Fixed by #25884
Labels
tv TV-related features

Comments

@Rajashreekalmane
Copy link

Problem
When running [TC_MC_4.1], Step 1, the Mac Address returned is Empty for wake-on-lan-mac-address attribute for the wakeonlan cluster.
Expect to see the mac address of the device, in this case, the Linux device running chip-tv-app.

image

Command used to build the TV-app
built the tv-app in linux using scripts/examples/gn_build_example.sh examples/tv-app/linux/ examples/tv-app/linux/out/tv-app chip_inet_config_enable_ipv4=false chip_enable_wake_on_lan=true

GitHub hash of the SDK that was being used
2767b51 - Master

PFA Log below
image

TC-WAKEONLAN-4.1.txt

@bzbarsky-apple bzbarsky-apple added the tv TV-related features label Mar 23, 2023
@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Mar 23, 2023

The Linux version of WakeOnLanManager::HandleGetMacAddress is fairly broken (e.g. encodes char strings, not byte strings), but apart from that it seems to assume that /sys/class/net/eth0/address will exist and be the right thing, which it might well not be on the hardware you are running on... and it has no error handling around it not existing.

@chrisdecenzo
Copy link
Contributor

We can fix this to work on the RPI dummy linux tv-app DUT but each real device will likely need to tweak the implementation to use the correct interface.

@bzbarsky-apple
Copy link
Contributor

Sounds like the relevant part of the implementation should be in some sort of app-implemented provider instead of being hardcoded.....

@cjandhyala
Copy link
Contributor

@chrisdecenzo as long as we have it fixed on RPI in the tv-app, QA can verify this TC on reference platform. For actual cert testing, since this is a manual test, we"ll have the ATL verify the actual MAC address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tv TV-related features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants