Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [ICD] SimpleSubscriptionResumptionStorage should be made conditionally compiled in GN #24564

Closed
jtung-apple opened this issue Jan 20, 2023 · 0 comments · Fixed by #24653
Assignees
Labels
icd Intermittently Connected Devices

Comments

@jtung-apple
Copy link
Contributor

Reproduction steps

As is, SimpleSubscriptionResumptionStorage files makes use CHIP_CONFIG_PERSIST_SUBSCRIPTIONS in CHIPConfig.h (and related platform ones) to conditionally compile the class definition/implementation.

Per @andy31415 comment in #24361 (comment)

This issue is to track moving the conditional compilation to BUILD.gn system.

Bug prevalence

This is a build issue

GitHub hash of the SDK that was being used

b4c2827

Platform

core

Platform Version(s)

1.1

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icd Intermittently Connected Devices
Projects
None yet
1 participant