Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TLV] TLVReader::Get(CharSpan&) to Stop on ASCII Unit Separator #24419

Closed
emargolis opened this issue Jan 13, 2023 · 0 comments · Fixed by #24421
Closed

[TLV] TLVReader::Get(CharSpan&) to Stop on ASCII Unit Separator #24419

emargolis opened this issue Jan 13, 2023 · 0 comments · Fixed by #24421
Assignees
@emargolis

Comments

@emargolis
Copy link
Contributor

Feature description

The TLVReader::Get(CharSpan&) should always stops at the first ASCII Unit Separator codepoint (ascii 0x1F).

The rationale is that clients should never see garbage at the end of string due to localization IDs.

Platform

core

Platform Version(s)

0f32800

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emargolis emargolis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tlv] TLVReader::Get CharSpan to Stop on ASCII Unit Separator emargolis/connectedhomeip-1
1 participant
@emargolis