-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] UpdateNOC followed by MRP timeout leads to VerifyOrDie #23093
Comments
The feature that appears to be breaking is #19780:
Somehow, it appears there is a bad interaction with #19502, even though we intended for the two features to work correctly together. |
So in this case we have session 26511 which being used by exchange "28700r", which is the exchange the The sequence of events seems to be the following:
The right answer is either to remove the VerifyOrDie (and just ignore MarkAsDefunct in the evicted state), or to add checks at the MarkAsDefunct callsites in exchange manager and MRP that the session is not in the evicted state. |
Honestly, I would prefer the "remove the VerifyOrDie" approach. |
I'm fine with the ignoring the |
Makes sense to me as well. |
CC @gharveymn |
Reproduction steps
From the log:
Bug prevalence
Will likely always occur with an MRP timeout closely following after UpdateNOC
GitHub hash of the SDK that was being used
fa8db56
Platform
other
Platform Version(s)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: