Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Add Attestation Certificate Format Validation Method #22942

Closed
emargolis opened this issue Sep 28, 2022 · 0 comments · Fixed by #22943
Closed

[1.0] Add Attestation Certificate Format Validation Method #22942

emargolis opened this issue Sep 28, 2022 · 0 comments · Fixed by #22943
Assignees
@emargolis

Comments

@emargolis
Copy link
Contributor

Reproduction steps

When Commissioner is doing PAI and DAC attestation flow it is required to verify that the certificate format is valid and Spec compliant. Currently, the SDK doesn't do that. 

There are many attestation test vector with malformed certificates:
    credentials/development/commissioner_dut/
Many of these malformed certificates will pass validation by the commissioner.

Need to verify that malformed certificates that are not Spec compliant fail attestation.

Bug prevalence

100% of the time

GitHub hash of the SDK that was being used

46fd14a

Platform

core

Platform Version(s)

No response

Type

Spec Compliance Issue

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emargolis emargolis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Attestation Certificate Format Validation Method. emargolis/connectedhomeip-1
1 participant
@emargolis