[BUG] DeviceControllerFactory::InitSystemState initializes FabricTable, but DeviceControllerSystemState::Shutdown() does not shut it down

[msandstedt]

Reproduction steps

Can be discovered by inspection.

FabricTable::Init is called here:

connectedhomeip/src/controller/CHIPDeviceControllerFactory.cpp

Line 184 in 33b4fab

ReturnErrorOnFailure(newFabricTable->Init(fabricTableInitParams));

FabricTable::Shutdown is not called here:

connectedhomeip/src/controller/CHIPDeviceControllerFactory.cpp

Line 464 in 33b4fab

if (mTempFabricTable != nullptr)

This can likely lead to leaks if FabricTable isn't freeing its dynamically allocated memory with Shutdown, e.g. these allocations:

connectedhomeip/src/credentials/FabricTable.cpp

Line 257 in 852c879

mOperationalKey = chip::Platform::New<P256Keypair>();

It was also discovered on adding the missing shutdown that the Python controller frees the storage delegate injected into the Fabric Table before the Fabric Table is freed, leading to use-after-free. That is addressed here:

#22963

Bug prevalence

Always occurs if DeviceControllerFactory allocates the FabricTable

GitHub hash of the SDK that was being used

33b4fab

Platform

other (controllers)

Platform Version(s)

No response

Anything else?

No response

[msandstedt]

CC @gharveymn