Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Apply darwin API review changes to MTRKeypair #22538

Closed
bzbarsky-apple opened this issue Sep 12, 2022 · 2 comments
Closed

[Platform] Apply darwin API review changes to MTRKeypair #22538

bzbarsky-apple opened this issue Sep 12, 2022 · 2 comments
Assignees
Labels
darwin p2 priority 2 work v1.2
Milestone

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 12, 2022

Reproduction steps

  1. Make publicKey be a readonly property, not a "method". This needs to be done a bit carefully to avoid compile issues and leaks.
  2. Switch signing functions to one function that takes an enum for what sort of signature to produce (RAW or DER).
  3. Add a way to ask the delegate for a bitmask indicating which signature types it supports.

Part of #22420 and looks like it's independent of the other work going on for that issue.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 18, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Mar 18, 2023
@woody-apple woody-apple added v1.2 p2 priority 2 work and removed v1.1 labels Apr 4, 2023
@woody-apple woody-apple added this to the 1.2 milestone Jun 23, 2023
@woody-apple
Copy link
Contributor

Closing this, given this has shipped, and more complicated to change the API surface at this point.

@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darwin p2 priority 2 work v1.2
Projects
Archived in project
Development

No branches or pull requests

2 participants