Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Commissioner attestation delegate should be able to override success #22423

Closed
jtung-apple opened this issue Sep 6, 2022 · 0 comments · Fixed by #22321
Closed

[1.0] Commissioner attestation delegate should be able to override success #22423

jtung-apple opened this issue Sep 6, 2022 · 0 comments · Fixed by #22321
Assignees

Comments

@jtung-apple
Copy link
Contributor

Reproduction steps

The SDK currently allows an attestation delegate to override an attestation failure in response to user preference. The attestation delegate should also be able to override attestation success, in case application logic decides to stop commissioning a device.

Bug prevalence

N/A

GitHub hash of the SDK that was being used

0f0e1e9

Platform

darwin, core

Platform Version(s)

No response

Type

Platform Issue

Anything else?

why is this important

This is required for third party developers on iOS to verify device attestation.

what is the sideffect if we decide to not accept this change into 1.0 branch or if we fail to finish its development?

Once commissioning starts, third party developers would not be able to reject attestation results, even if they have more verification information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant