Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fallback mechanism from rpc_service for getting device information #22266

Closed
shubhamdp opened this issue Aug 30, 2022 · 0 comments · Fixed by #23175
Closed

Remove the fallback mechanism from rpc_service for getting device information #22266

shubhamdp opened this issue Aug 30, 2022 · 0 comments · Fixed by #23175
Assignees

Comments

@shubhamdp
Copy link
Contributor

shubhamdp commented Aug 30, 2022

Problem

We still have fallback mechanism for some configurations in rpc_server. Please check the below example for getting vendor id.

if (DeviceLayer::GetDeviceInstanceInfoProvider()->GetVendorId(vendor_id) == CHIP_NO_ERROR)
{
response.vendor_id = static_cast<uint32_t>(vendor_id);
}
else
{
response.vendor_id = CHIP_DEVICE_CONFIG_DEVICE_VENDOR_ID;
}

Proposed Solution

Please remove the fallbacks options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants