Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Java interface cleanup work #21608

Closed
chrisdecenzo opened this issue Aug 3, 2022 · 2 comments
Closed

Android Java interface cleanup work #21608

chrisdecenzo opened this issue Aug 3, 2022 · 2 comments
Labels
android stale Stale issue or PR

Comments

@chrisdecenzo
Copy link
Contributor

chrisdecenzo commented Aug 3, 2022

Problem

  • ChipDeviceController.java - consider replacing setUseJavaCallbackForNOCRequest with an implicit check for the assignment of the constructor from AndroidOperationalCredentialsIssuer::GenerateNOCChain
  • ChipDeviceController.java onNOCChainGenerationNeeded - consider breaking arguments into separate objects to reduce the parameter count and also make it less likely to mix up the parameters (since they are all of type byte[]), eg:
class NOCChainParams {
  byte[] getCsrElements()
  byte[] getCsrNonce()
}
  • ControllerParams.java - consider isolate fields like attemptNetworkScanWiFi and attemptNetworkScanThread into some wrapper class like AutoCommissionerConfig to make clear that they apply to AutoCommissioner.

(from #21522)

Proposed Solution

  • consider the above
@stale
Copy link

stale bot commented Feb 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 4, 2023
@stale
Copy link

stale bot commented Feb 12, 2023

This stale issue has been automatically closed. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android stale Stale issue or PR
Projects
Archived in project
Development

No branches or pull requests

2 participants