Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop BdxOTASender polling timer after EOF on Darwin #21388

Closed
pgravel-com opened this issue Jul 29, 2022 · 1 comment · Fixed by #21424
Closed

Stop BdxOTASender polling timer after EOF on Darwin #21388

pgravel-com opened this issue Jul 29, 2022 · 1 comment · Fixed by #21424

Comments

@pgravel-com
Copy link

Polling timer is never stopped after successful file transfer when using src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

Step to reproduce -
Add log to BdxOTASender:HandleTransferSessionOutput for visibility
Initiate BDX OTA firmware update transfer
Wait for EOF
See timer still firing after EOF and log getting printed.

15:39:53.310 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kAckEOFReceived
15:39:53.317 E  [BDX] OnTransferSessionEnd
15:39:53.317 E  [BDX] BdxOTASender::Reset
15:39:53.378 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.437 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.496 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.553 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.605 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.661 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.717 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.770 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.825 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.887 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:53.952 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:54.013 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:54.080 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:54.144 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
15:39:54.204 E  [BDX] BdxOTASender::HandleTransferSessionOutput - kNone
...

As per https://github.com/project-chip/connectedhomeip/blob/master/examples/ota-provider-app/ota-provider-common/BdxOtaSender.cpp#L183 , mStopPolling should be set to TRUE on AckEOF or possibly in Reset().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants