Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Android handling of short discriminators #21238

Closed
bzbarsky-apple opened this issue Jul 26, 2022 · 4 comments
Closed

Address Android handling of short discriminators #21238

bzbarsky-apple opened this issue Jul 26, 2022 · 4 comments
Assignees
Labels

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

In #21187 I left the Android behavior around short discriminators the same as it was before: they are 0-padded to look like a long discriminator with all low bits 0. This happens in two places:

  1. BLEManagerImpl::NewConnection in src/platform/android/BLEManagerImpl.cpp
  2. TransformSetupPayload in src/setup_payload/java/SetupPayloadParser-JNI.cpp

Proposed Solution

What needs to happen is to figure out how short discriminators should actually be handled in the Android API and handle them accordingly.

@123yangu
Copy link

123yangu commented Jan 3, 2023

@bzbarsky-apple Do I have this problem to solve?

@bzbarsky-apple
Copy link
Contributor Author

@123yangu I don't understand what you're asking.

@yunhanw-google
Copy link
Contributor

@joonhaengHeo could you hep check whether this has been resolved. thanks

@joonhaengHeo
Copy link
Contributor

I already added pairWithCode API. (#26324)
And, if using Manual Pairing Code, proceed with BLE discover with Short Discriminator.

@github-project-automation github-project-automation bot moved this from In Progress to Done in [Platform] Android Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants