Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-ACL-2.4]: Test case ,Step 32: Expected output is constraint error , But the actual result is Failure #20794

Closed
aswathygrl opened this issue Jul 15, 2022 · 3 comments · Fixed by #20736

Comments

@aswathygrl
Copy link

Test Case ID
TC-ACL-2.4
Describe Issue:
Step 32 :expected outcome is constraint error but result is Failure.
Command to Verify: ./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null}, {"fabricIndex": 1, "privilege": 6, "authMode": 2, "subjects": null, "targets":null}]' 1 0
Specification References:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/ACL-Cluster.adoc#error-handling
Test Plan Reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/AccessControl.adoc#tc-acl-2-4-acl-attribute

@bzbarsky-apple
Copy link
Contributor

@andy31415 Is this not fixed by #20736 ?

@andy31415
Copy link
Contributor

@bzbarsky-apple Testing it now.

I believe our privilege mappins are bit-fields, so 6 seemed to pass for me, but I have to try again. For this one I need to understand if the test case is bad or the code has bugs or my manual test was bad.

@andy31415
Copy link
Contributor

Re-tested and it is indeed fixed. I think I had an error in my manual test before. I will mark it as such.

@aswathygrl sorry for making you break these up... I really thought that my PR did not fix them, but it turns out I made manual errors when double-checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants