Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVE1] zap sets old cluster revisions by default for Identify Server Cluster (version 2 instead of 4) #20607

Closed
markus-becker-tridonic-com opened this issue Jul 12, 2022 · 9 comments · Fixed by #20636
Assignees

Comments

@markus-becker-tridonic-com
Copy link
Contributor

Problem

When creating a new EP and e.g. create an Identify Server Cluster, zap fills in version 2 for the Cluster Revision of Identify. Current value is 4.

Proposed Solution

Set the latest ClusterRevision by default.

@andy31415 andy31415 changed the title [SVE1] zap sets old cluster revisions by default [SVE1] zap sets old cluster revisions by default for Identify Server Cluster (version 2 instead of 4) Jul 12, 2022
@andy31415
Copy link
Contributor

I updated the issue title. @markus-becker-tridonic-com - is this specific for identify or will it set 'revision 2' for any cluster?

Is this a zap UI issue or how are you creating the new endpoint?

@markus-becker-tridonic-com
Copy link
Contributor Author

I noticed this only for Identify when adding a new endpoint and adding the server cluster. Might not be limited to Identify Server cluster though. Yes, I was using the ZAP UI.

@andy31415
Copy link
Contributor

Maybe this should be reported to zap? @tecimovic - how do we triage and split bugs between zap and matter sdk?

@andy31415 andy31415 self-assigned this Jul 12, 2022
@andy31415
Copy link
Contributor

Assigning myself to validate that our XML is correct. Assume that zap takes the value from the xml.

@andy31415
Copy link
Contributor

Current XML in identify seems to say:

<globalAttribute side="either" code="0xFFFD" value="2"/>

I belive this is revision given that the value is 2. I will update and see if anything else can be validated globally. Checking cluster revisions manually seems somewhat painful.

@andy31415
Copy link
Contributor

illuminance-measurement-cluster.xml has 2 instead of 3

@andy31415
Copy link
Contributor

andy31415 commented Jul 12, 2022

pressure-measurement has 2 instead of 3

@andy31415
Copy link
Contributor

Created a diffs script, revisions mismatches:
0x0004 should be 4 not 3
0x0301 should be 4 not 3
0x0406 should be 3 not 2

Several other clusters I could not properly parse spec vs code. The spec adocs are too free form.

@andy31415
Copy link
Contributor

All the above remaining clusters are not in the /chip/ location but are rather silabs, so I will not update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants