-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVE1] zap sets old cluster revisions by default for Identify Server Cluster (version 2 instead of 4) #20607
Comments
I updated the issue title. @markus-becker-tridonic-com - is this specific for identify or will it set 'revision 2' for any cluster? Is this a zap UI issue or how are you creating the new endpoint? |
I noticed this only for Identify when adding a new endpoint and adding the server cluster. Might not be limited to Identify Server cluster though. Yes, I was using the ZAP UI. |
Maybe this should be reported to zap? @tecimovic - how do we triage and split bugs between zap and matter sdk? |
Assigning myself to validate that our XML is correct. Assume that zap takes the value from the xml. |
Current XML in identify seems to say:
I belive this is revision given that the value is 2. I will update and see if anything else can be validated globally. Checking cluster revisions manually seems somewhat painful. |
illuminance-measurement-cluster.xml has 2 instead of 3 |
pressure-measurement has 2 instead of 3 |
Created a diffs script, revisions mismatches: Several other clusters I could not properly parse spec vs code. The spec adocs are too free form. |
All the above remaining clusters are not in the /chip/ location but are rather silabs, so I will not update them. |
Problem
When creating a new EP and e.g. create an Identify Server Cluster, zap fills in version 2 for the Cluster Revision of Identify. Current value is 4.
Proposed Solution
Set the latest ClusterRevision by default.
The text was updated successfully, but these errors were encountered: