Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bdx TransferFacilitator to allow for cancelling the PollTimerHandler #20187

Closed
hubTab opened this issue Jun 30, 2022 · 0 comments · Fixed by #20192
Closed

Update Bdx TransferFacilitator to allow for cancelling the PollTimerHandler #20187

hubTab opened this issue Jun 30, 2022 · 0 comments · Fixed by #20192

Comments

@hubTab
Copy link
Contributor

hubTab commented Jun 30, 2022

Problem

In the BdxOtaSender::TransferFacilitator.cpp there is no way currently to cancel the PollTimerHandler, as needed, when receiving an kAckEOFReceived . The problem is that calling chip::DeviceLayer::SystemLayer().CancelTimer(PollTimerHandler, this); upon receiving kAckEOFReceived, it does not cancel the PollTimerHandler, as TransferFacilitator::PollForOutput() re-registers it.

Proposed Solution

While the BdxOtaSender was provided as en example, that terminates when upon completing the Bdx transfer, the TransferFacilitator.cpp needs to allow cancelling the PollTimerHandler.

To accomplish it, adding a mStopPolling flag in TransferFacilitator::PollForOutput() allowed for cancelling the PollTimerHandler.

Testing

Using a full OTA Download using M5Stack, enabled with OTA Requestor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant