You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the BdxOtaSender::TransferFacilitator.cpp there is no way currently to cancel the PollTimerHandler, as needed, when receiving an kAckEOFReceived . The problem is that calling chip::DeviceLayer::SystemLayer().CancelTimer(PollTimerHandler, this); upon receiving kAckEOFReceived, it does not cancel the PollTimerHandler, as TransferFacilitator::PollForOutput() re-registers it.
Proposed Solution
While the BdxOtaSender was provided as en example, that terminates when upon completing the Bdx transfer, the TransferFacilitator.cpp needs to allow cancelling the PollTimerHandler.
To accomplish it, adding a mStopPolling flag in TransferFacilitator::PollForOutput() allowed for cancelling the PollTimerHandler.
Testing
Using a full OTA Download using M5Stack, enabled with OTA Requestor.
The text was updated successfully, but these errors were encountered:
Problem
In the BdxOtaSender::TransferFacilitator.cpp there is no way currently to cancel the PollTimerHandler, as needed, when receiving an kAckEOFReceived . The problem is that calling
chip::DeviceLayer::SystemLayer().CancelTimer(PollTimerHandler, this);
upon receiving kAckEOFReceived, it does not cancel the PollTimerHandler, as TransferFacilitator::PollForOutput() re-registers it.Proposed Solution
While the BdxOtaSender was provided as en example, that terminates when upon completing the Bdx transfer, the TransferFacilitator.cpp needs to allow cancelling the PollTimerHandler.
To accomplish it, adding a mStopPolling flag in TransferFacilitator::PollForOutput() allowed for cancelling the PollTimerHandler.
Testing
Using a full OTA Download using M5Stack, enabled with OTA Requestor.
The text was updated successfully, but these errors were encountered: