Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session resumption broken in nrfconnect #20169

Closed
msandstedt opened this issue Jun 30, 2022 · 6 comments
Closed

Session resumption broken in nrfconnect #20169

msandstedt opened this issue Jun 30, 2022 · 6 comments

Comments

@msandstedt
Copy link
Contributor

Problem

Tested at this rev:

commit 31ddf98b8100c2388e731bc757526c41e288198e (origin/master, origin/HEAD)
Author: Boris Zbarsky <[email protected]>
Date:   Thu Jun 30 09:57:40 2022 -0400

    Assume external attributes that must be non-volatile actually are. (#20144)

If a controller sends valid Sigma1 containing session resumption information, the nrf will never retrieve its session resumption record and always responds with Sigma2.

A similar thing was observed with ESP32. In the case of that platform, this resolved it: #18604

Proposed Solution

  • Verify whether key length is breaking session resumption on nrfconnect as it had broken it on ESP32
  • Make nrfconnect support longer kvstore keys
  • OR refactor session resumption storage strategy to use shorter keys
@msandstedt
Copy link
Contributor Author

CC @kghost , @kianooshkarami

@bzbarsky-apple
Copy link
Contributor

@kkasperczyk-no
Copy link
Contributor

The reason of this problem is that Zephyr KVS backend doesn't support processing = character that is used in the CASE session key name. In case of replacing this character with some other character resumption seems to be working fine. It will be fixed by @Damian-Nordic altogether with other changes related to the KVS and discovered during persistent storage audit.

@kkasperczyk-no
Copy link
Contributor

kkasperczyk-no commented Jul 6, 2022

It should be fixed after #20298 was merged.

@msandstedt
Copy link
Contributor Author

@kkasperczyk-no ,

I'll give it a try! Thanks!

@msandstedt
Copy link
Contributor Author

I have not checked, but I'm presuming this is fixed since zephyr now passes the storage audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants