Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell check broken by #19043 #19776

Closed
cpagravel opened this issue Jun 20, 2022 · 2 comments · Fixed by #19777
Closed

Spell check broken by #19043 #19776

cpagravel opened this issue Jun 20, 2022 · 2 comments · Fixed by #19777

Comments

@cpagravel
Copy link
Contributor

Problem

Proposed Solution

  • Fix the spellcheck CI.

We should consider avoiding merges if CI jobs are broken. In that particular PR there are only 59 of 66 checks passing.
@cpagravel
Copy link
Contributor Author

@arkq could you take a look at this?

@bzbarsky-apple bzbarsky-apple linked a pull request Jun 20, 2022 that will close this issue
Fixes CI spellcheck that stopped working on #19043 #19777
Merged
@arkq
Copy link
Contributor

arkq commented Jun 21, 2022

We should consider avoiding merges if CI jobs are broken. In that particular PR there are only 59 of 66 checks passing.

Sorry for that, I've missed that the spell check has failed. Maybe it should be marked as required? @andy31415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes CI spellcheck that stopped working on #19043 rochaferraz/connectedhomeip
2 participants
@arkq @cpagravel