Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Objects don't handle unknown enum/bitmap values well #19334

Closed
mrjerryjohns opened this issue Jun 8, 2022 · 3 comments · Fixed by #20907
Closed

Cluster Objects don't handle unknown enum/bitmap values well #19334

mrjerryjohns opened this issue Jun 8, 2022 · 3 comments · Fixed by #20907
Assignees
Labels
Interaction Model Work p1 priority 1 work spec Mismatch between spec and implementation sve V1.0

Comments

@mrjerryjohns
Copy link
Contributor

mrjerryjohns commented Jun 8, 2022

Problem

When decoding cluster elements that are of type enum* or bitmap* using the generated stuff in cluster-enums.h or cluster-objects.h, enum values that are not recognized still get silently decoded without any conveyance of failure.

This can result in un-defined behavior in application logic that is unaware that the decoded value is not actually valid against their compiled-in definition of that enumeration/bitmap.

While this won't practically be a problem till post 1.0, it's important to solve it before 1.0 since clients need to be built to be defensive now since upgrading them later is likely not always possible.

@mrjerryjohns mrjerryjohns added V1.0 Interaction Model Work spec Mismatch between spec and implementation labels Jun 8, 2022
@woody-apple
Copy link
Contributor

Spec Issue Review: Per @bzbarsky-apple we should confirm that this is a spec compliance issue, if not, remove the label. Still makes sense for 1.0 for forwards compatibility.

@mrjerryjohns
Copy link
Contributor Author

With #20907 merged, this issue is complete.

@mrjerryjohns mrjerryjohns linked a pull request Jul 19, 2022 that will close this issue
@bzbarsky-apple
Copy link
Contributor

@mrjerryjohns I don't think the bitmap part of this is done....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interaction Model Work p1 priority 1 work spec Mismatch between spec and implementation sve V1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants