Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-commissioning-window commands in test scripts not spec compliant #19266

Closed
agners opened this issue Jun 7, 2022 · 6 comments
Closed

open-commissioning-window commands in test scripts not spec compliant #19266

agners opened this issue Jun 7, 2022 · 6 comments

Comments

@agners
Copy link
Contributor

agners commented Jun 7, 2022

Problem

Several instructions in test YAML files suggest a chip-tool pairing open-commissioning-window command with not spec compliant timeout of 100s (instead of 180s).

$ grep -r -e "pairing open-commissioning-window [0-9]* [0-9]* 100" src
src/app/tests/suites/certification/Test_TC_MF_1_21.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_16.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_13.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_13.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_13.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_13.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_19.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_19.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_23.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_17.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_17.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_14.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_14.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_14.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_14.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_7.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840
src/app/tests/suites/certification/Test_TC_MF_1_7.yaml:          ./chip-tool pairing open-commissioning-window 1 1 100 1000 3840

Proposed Solution

Increase the value to 180s (unless the test case is about validating for failure).

@bzbarsky-apple
Copy link
Contributor

Please file an issue in https://github.com/CHIP-Specifications/chip-test-plans/ ...

@cjandhyala @manjunath-grl can we get these test scripts fixed, please?

@bzbarsky-apple bzbarsky-apple changed the title open-commissioning-window commands not spec compliant open-commissioning-window commands in test scripts not spec compliant Jun 7, 2022
@agners
Copy link
Contributor Author

agners commented Jun 7, 2022

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl test script has been updated. Please fix the YAML?

@manjunath-grl
Copy link
Contributor

@bzbarsky-apple the above mentioned testcases are Manual scripts, the validation sheet has been update we will update the scripts as per the sheet and make PR

@kowsisoundhar12
Copy link
Contributor

@bzbarsky-apple @agners updated above listed MF scripts,pls refer following PR's 20227,20127

@agners
Copy link
Contributor Author

agners commented Jul 5, 2022

LGTM.

@agners agners closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants