Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data version for ReadAttribute in CHIP.framework if OnDone is added. #18339

Closed
krypton36 opened this issue May 11, 2022 · 4 comments
Closed
Labels
darwin stale Stale issue or PR V1.X

Comments

@krypton36
Copy link
Contributor

Problem

#18174 PR add data version to write, but does not add data version to read, because when the data version matches the server data version no data is reported back. Since this API relies on a report callback or error callback, none of these callbacks are executed. In order to add to CHIP.framework and chip-tool-darwin, the ReadAttribute cluster API needs to expose the OnDone callback or data version needs to be removed from the API and any test plan that requires the controller to set the data version on read.

Proposed Solution

If the callback OnDone is added this issue is to be used to add to CHIP.framework and chip-tool-darwin. If the data version is removed, this issue is to be closed.

@woody-apple
Copy link
Contributor

Not clear this is required for V1.0, moving out of V1. @krypton36 please update if this isn't correct.

@krypton36
Copy link
Contributor Author

Not needed for V1.0

@stale
Copy link

stale bot commented Nov 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Nov 21, 2022
@stale
Copy link

stale bot commented Dec 3, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darwin stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

3 participants