Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network commissioning commands should set breadcrumb as needed. #17759

Closed
bzbarsky-apple opened this issue Apr 26, 2022 · 2 comments
Closed

Network commissioning commands should set breadcrumb as needed. #17759

bzbarsky-apple opened this issue Apr 26, 2022 · 2 comments
Assignees
@erjiaqing
Labels
spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

ScanNetworks, AddOrUpdateWiFiNetwork, AddOrUpdateThreadNetwork, RemoveNetwork, ConnectNetwork, ReorderNetwork are all supposed to set the breadcrumb if one is provided.

Proposed Solution

Implement that.
@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation labels Apr 26, 2022
@bzbarsky-apple
Copy link
Contributor Author

@yufengwangca @erjiaqing @tcarmelveilleux Just FYI, in case one of you has time for this.

@bzbarsky-apple bzbarsky-apple mentioned this issue May 5, 2022
Closed
@erjiaqing erjiaqing self-assigned this May 10, 2022
@erjiaqing erjiaqing mentioned this issue May 11, 2022
Merged
@bzbarsky-apple
Copy link
Contributor Author

Fixed in #18303 (but the typo there meant they did not get linked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erjiaqing erjiaqing

Labels
spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erjiaqing @bzbarsky-apple