Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate addition of DrainAndServiceIO to TestReadInteraction #17528

Closed
mrjerryjohns opened this issue Apr 19, 2022 · 2 comments
Closed

Investigate addition of DrainAndServiceIO to TestReadInteraction #17528

mrjerryjohns opened this issue Apr 19, 2022 · 2 comments
Labels

Comments

@mrjerryjohns
Copy link
Contributor

Problem

As part of #17426, I had to add an extra DrainAndServiceIO call to TestReadInteraction. While the changes to ReadHandler in that PR may look substantial, the smallest delta to that PR that triggered the addition above was to add the following in ReadHandler.cpp:

        else if (IsType(InteractionType::Subscribe))
        {
            if (IsPriming())
            {
                err = SendSubscribeResponse();

                mpExchangeCtx = nullptr;
                SuccessOrExit(err);

                mActiveSubscription = true;

                auto * appCallback = mManagementCallback.GetAppCallback();
                if (appCallback)
                {
                    appCallback->OnSubscriptionEstablished(*this);
                }
            }
            else
            {
                MoveToState(HandlerState::GeneratingReports);
                mpExchangeCtx = nullptr;
            }

            //
            // This is the line if added, causes the test to fail.
            SuccessOrExit(err = InteractionModelEngine::GetInstance()->GetReportingEngine().ScheduleRun());
        }
@stale
Copy link

stale bot commented Oct 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 18, 2022
@stale
Copy link

stale bot commented Oct 28, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant