You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The driver interface is not documented very well, so the implementations of it differ in how they handle the SSID. For example, src/platform/Ameba/NetworkCommissioningWiFiDriver.cpp checks ssid.data() to decide whether we're doing a single-ssid scan or general scan, while src/platform/EFR32/NetworkCommissioningWiFiDriver.cpp checks ssid.size(). If we checked the size in the caller and enforced the "1 to 32" length constraint, the difference would at least not be observable, but as it is they would reply differently to the same protocol message.
We should:
Check the 1 to 32 length constraint in the cluster code and respond with an error if given a non-null 0-length SSID. Though maybe an empty SSID should be allowed here in spite of the constraint saying "1 to 32" because this is nullable? @CamWms
Change the driver API to have separate functions for "scan for networks with the given SSID" and "scan for all networks" so the only place where we have to make that decision is in the cluster code and drivers can just do what they're told.
If we want that behavior, we can implement that too (need to sort out what the actual spec behavior here is). But that decision should be made in one place: in the cluster.
The driver interface is not documented very well, so the implementations of it differ in how they handle the SSID. For example,
src/platform/Ameba/NetworkCommissioningWiFiDriver.cpp
checksssid.data()
to decide whether we're doing a single-ssid scan or general scan, whilesrc/platform/EFR32/NetworkCommissioningWiFiDriver.cpp
checksssid.size()
. If we checked the size in the caller and enforced the "1 to 32" length constraint, the difference would at least not be observable, but as it is they would reply differently to the same protocol message.We should:
Originally posted by @bzbarsky-apple in #17038 (comment)
The text was updated successfully, but these errors were encountered: