Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do we do when we abort? #14197

Closed
woody-apple opened this issue Jan 25, 2022 · 3 comments
Closed

What do we do when we abort? #14197

woody-apple opened this issue Jan 25, 2022 · 3 comments
Assignees
Labels
qpg QPG6xxx platform stale Stale issue or PR todo 🗒️ V1.X

Comments

@woody-apple
Copy link
Contributor

false


// TODO: What do we do when we abort?
ChipLogProgress(SoftwareUpdate, "Q: HandleAbort");
remove(imageProcessor->mParams.imageFile.data());
imageProcessor->ReleaseBlock();
}


This issue was generated by todo-issue based on a TODO comment in e169fcf.
@holbrookt
Copy link
Contributor

Assigning to @tima-q who introduced this TODO. Doesn't seem critical for 1.0

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 13, 2022
@tima-q
Copy link
Contributor

tima-q commented Aug 22, 2022

TODO removed in subsequent updates. Abort will reset received bytes - updated in #14388

@tima-q tima-q closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qpg QPG6xxx platform stale Stale issue or PR todo 🗒️ V1.X
Projects
None yet
Development

No branches or pull requests

5 participants