Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal mdns should send Rmv notifications as needed #13793

Closed
bzbarsky-apple opened this issue Jan 20, 2022 · 3 comments
Closed

Minimal mdns should send Rmv notifications as needed #13793

bzbarsky-apple opened this issue Jan 20, 2022 · 3 comments
Labels
commissioning Involves placing devices on the network, initial setup V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

If a node is commissionable, it publishes records with CM=1.

When it stops being commissionable, it should stop advertising those. Right now platform mdns seems to handle this right, but minimal mdns does not.

Proposed Solution

Fix minimal mdns to send Rmv notifications for the CM=1 records, so we are not incorrectly advertising ourselves as being commissionable until the TTL is hit

@andy31415

@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Jan 20, 2022
@turon turon added the commissioning Involves placing devices on the network, initial setup label Feb 1, 2022
@turon
Copy link
Contributor

turon commented Feb 1, 2022

Minimal mdns must be spec compliant for v1.
Removing tag v1_triage_split_4

@woody-apple
Copy link
Contributor

SDK Spec Review: We do not believe this is a spec requirement for 1.0.

@woody-apple woody-apple removed the spec Mismatch between spec and implementation label May 25, 2022
@andy31415
Copy link
Contributor

#19692 makes minmdns send a TTL=0 on services removed.

I believe this should address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commissioning Involves placing devices on the network, initial setup V1.0
Projects
None yet
Development

No branches or pull requests

4 participants